Zhiyi Zhang : explorer: Zero initialize DEVMODE before passing it to EnumDisplaySettings().

Alexandre Julliard julliard at winehq.org
Tue Aug 11 16:26:50 CDT 2020


Module: wine
Branch: master
Commit: c9d2b62926883e7952a4585d09c6aa73335e9ede
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=c9d2b62926883e7952a4585d09c6aa73335e9ede

Author: Zhiyi Zhang <zzhang at codeweavers.com>
Date:   Tue Aug 11 18:16:33 2020 +0800

explorer: Zero initialize DEVMODE before passing it to EnumDisplaySettings().

EnumDisplaySettings() on Wine does not write beyond the end of DEVMODE because it doesn't use
dmDriverExtra currently, but this implementation detail should not be relied on.

Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/explorer/desktop.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c
index 691db5c8bd..6f1ff54c14 100644
--- a/programs/explorer/desktop.c
+++ b/programs/explorer/desktop.c
@@ -889,6 +889,7 @@ static void initialize_display_settings(void)
 
     /* Store current display mode in the registry */
     ddW.cb = sizeof(ddW);
+    memset(&dmW, 0, sizeof(dmW));
     dmW.dmSize = sizeof(dmW);
     while (EnumDisplayDevicesW( NULL, i++, &ddW, 0 ))
     {




More information about the wine-cvs mailing list