Arkadiusz Hiler : Revert "ntdll/tests: Add test to check if GetTickCount is updated after sleeping.".

Alexandre Julliard julliard at winehq.org
Mon Aug 24 15:58:51 CDT 2020


Module: wine
Branch: master
Commit: 9012096b47d8422a296734ecbedb226188e93501
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=9012096b47d8422a296734ecbedb226188e93501

Author: Arkadiusz Hiler <ahiler at codeweavers.com>
Date:   Tue Aug 18 16:27:15 2020 +0300

Revert "ntdll/tests: Add test to check if GetTickCount is updated after sleeping.".

This reverts commit 4617f83fcf0a34fe41b0e38dde1567195395efca.

The assumption that GetTickCount() gets updated after Sleep(1) holds only
when there is no other software running on the system. If any program uses
timeBeginPeriod() with values 1-15 then this assumption breaks.

A lot of common user software calls timeBeginPeriod() - this includes browsers,
media players, voice communicators, IDEs and store fronts.

Signed-off-by: Arkadiusz Hiler <ahiler at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntdll/tests/time.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/dlls/ntdll/tests/time.c b/dlls/ntdll/tests/time.c
index a00d507e4e..d756a8c839 100644
--- a/dlls/ntdll/tests/time.c
+++ b/dlls/ntdll/tests/time.c
@@ -199,7 +199,7 @@ static void test_user_shared_data_time(void)
 {
     KSHARED_USER_DATA *user_shared_data = (void *)0x7ffe0000;
     ULONGLONG t1, t2, t3;
-    int i = 0, changed = 0;
+    int i = 0;
 
     i = 0;
     do
@@ -253,15 +253,6 @@ static void test_user_shared_data_time(void)
            "USD InterruptTime / RtlQueryUnbiasedInterruptTime are out of order %s %s\n",
            wine_dbgstr_longlong(t2), wine_dbgstr_longlong(t3));
     }
-
-    for (i = 0; i < 100; i++)
-    {
-        t1 = GetTickCount();
-        Sleep(1);
-        t2 = GetTickCount();
-        if (t1 != t2) changed++;
-    }
-    todo_wine ok(changed >= 90, "tick count isn't updated after sleeping one millisecond (%d%% correct)\n", changed);
 }
 
 START_TEST(time)




More information about the wine-cvs mailing list