Zebediah Figura : Revert "winegstreamer: Avoid performing color matrix conversions in videoconvert.".

Alexandre Julliard julliard at winehq.org
Mon Dec 7 15:51:32 CST 2020


Module: wine
Branch: master
Commit: 251262a44a8f8403fd963e7bb510da778944af1b
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=251262a44a8f8403fd963e7bb510da778944af1b

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Sun Dec  6 10:19:11 2020 -0600

Revert "winegstreamer: Avoid performing color matrix conversions in videoconvert.".

This reverts commit fd25ba65e0eb9fedfb2cdfa2b7a4b16e0401dfdf.

The relevant commit breaks visual correctness in many applications, for the sake
of performance. As such I am rather inclined to revert it for 6.0, especially as
a full solution will probably involve a revert of this patch along with upstream
changes to GStreamer.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49535
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winegstreamer/gstdemux.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index e227ed9331d..77204bc55a2 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -1024,9 +1024,6 @@ static void init_new_decoded_pad(GstElement *bin, GstPad *pad, struct gstdemux *
             goto out;
         }
 
-        /* Avoid expensive color matrix conversions. */
-        gst_util_set_object_arg(G_OBJECT(vconv), "matrix-mode", "none");
-
         /* GStreamer outputs RGB video top-down, but DirectShow expects bottom-up. */
         if (!(flip = gst_element_factory_make("videoflip", NULL)))
         {




More information about the wine-cvs mailing list