Zebediah Figura : mp3dmod: Release a held buffer on destruction.

Alexandre Julliard julliard at winehq.org
Wed Feb 26 16:14:06 CST 2020


Module: wine
Branch: master
Commit: 88357e92f12f34fb40819b2c6319e2679175cc83
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=88357e92f12f34fb40819b2c6319e2679175cc83

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Wed Feb 26 00:19:22 2020 -0600

mp3dmod: Release a held buffer on destruction.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mp3dmod/mp3dmod.c       | 2 ++
 dlls/mp3dmod/tests/mp3dmod.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/mp3dmod/mp3dmod.c b/dlls/mp3dmod/mp3dmod.c
index 592ee5482a..65b48de711 100644
--- a/dlls/mp3dmod/mp3dmod.c
+++ b/dlls/mp3dmod/mp3dmod.c
@@ -103,6 +103,8 @@ static ULONG WINAPI Unknown_Release(IUnknown *iface)
 
     if (!refcount)
     {
+        if (This->buffer)
+            IMediaBuffer_Release(This->buffer);
         if (This->intype_set)
             MoFreeMediaType(&This->intype);
         MoFreeMediaType(&This->outtype);
diff --git a/dlls/mp3dmod/tests/mp3dmod.c b/dlls/mp3dmod/tests/mp3dmod.c
index 1d404248cc..e66ad3ace0 100644
--- a/dlls/mp3dmod/tests/mp3dmod.c
+++ b/dlls/mp3dmod/tests/mp3dmod.c
@@ -239,7 +239,7 @@ static void test_convert(void)
     ok(hr == S_OK, "got %#x\n", hr);
 
     IMediaObject_Release(dmo);
-    todo_wine ok(inbuf.refcount == 1, "Got outstanding refcount %d.\n", inbuf.refcount);
+    ok(inbuf.refcount == 1, "Got outstanding refcount %d.\n", inbuf.refcount);
     ok(outbuf.refcount == 1, "Got outstanding refcount %d.\n", outbuf.refcount);
 }
 




More information about the wine-cvs mailing list