Francois Gouget : testbot/Janitor: Deleting a pending series is not an error.

Alexandre Julliard julliard at winehq.org
Fri Jan 10 11:59:00 CST 2020


Module: tools
Branch: master
Commit: d3cc3d42ae1c91b063867b4a512bf1075d71b1ee
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=d3cc3d42ae1c91b063867b4a512bf1075d71b1ee

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Jan 10 13:13:57 2020 +0100

testbot/Janitor: Deleting a pending series is not an error.

Maybe the author abandonned it or some email server dropped some part.
So just trace the deletion and the pending parts so we know which were
missing.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/bin/Janitor.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl
index 9ee5517..4eda071 100755
--- a/testbot/bin/Janitor.pl
+++ b/testbot/bin/Janitor.pl
@@ -148,9 +148,10 @@ my $DeleteBefore = time() - 1 * 86400;
 my $Sets = CreatePendingPatchSets();
 foreach my $Set (@{$Sets->GetItems()})
 {
-  my $MostRecentPatch;
+  my ($MostRecentPatch, @Parts);
   foreach my $Part (@{$Set->Parts->GetItems()})
   {
+    push @Parts, $Part->No;
     my $Patch = $Part->Patch;
     if (! defined($MostRecentPatch) ||
         $MostRecentPatch->Received < $Patch->Received)
@@ -161,7 +162,7 @@ foreach my $Set (@{$Sets->GetItems()})
   if (! defined($MostRecentPatch) ||
       $MostRecentPatch->Received < $DeleteBefore)
   {
-    Error "Deleting pending series for ", $Set->EMail, "\n";
+    Trace "Deleting pending series for ", $Set->EMail, " (got ", join(" ", sort @Parts), " / ", $Set->TotalParts, ")\n";
     next if ($DryRun);
 
     $Sets->DeleteItem($Set);




More information about the wine-cvs mailing list