Alistair Leslie-Hughes : dmime: IDirectMusicPerformance8_FreePMsg Release the unknown pointer.

Alexandre Julliard julliard at winehq.org
Wed Jan 22 14:53:00 CST 2020


Module: wine
Branch: master
Commit: 55827134d19135328ecd0fa5a11067c12e5a1a01
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=55827134d19135328ecd0fa5a11067c12e5a1a01

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Tue Jan 21 22:24:46 2020 +0100

dmime: IDirectMusicPerformance8_FreePMsg Release the unknown pointer.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/dmime/performance.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/dmime/performance.c b/dlls/dmime/performance.c
index 2124c1fe35..3dd54a6cb6 100644
--- a/dlls/dmime/performance.c
+++ b/dlls/dmime/performance.c
@@ -531,7 +531,9 @@ static HRESULT WINAPI IDirectMusicPerformance8Impl_FreePMsg(IDirectMusicPerforma
   DMUS_ItemRemoveFromQueue( This, pItem );
   LeaveCriticalSection(&This->safe);
 
-  /** TODO: see if we should Release the pItem->pMsg->punkUser and others Interfaces */
+  if (pPMSG->punkUser)
+    IUnknown_Release(pPMSG->punkUser);
+
   HeapFree(GetProcessHeap(), 0, pItem);  
   return S_OK;
 }




More information about the wine-cvs mailing list