Nikolay Sivov : ole32: Fix a leak when creating pointer moniker through activation.

Alexandre Julliard julliard at winehq.org
Tue Jun 2 08:11:18 CDT 2020


Module: wine
Branch: stable
Commit: ba06f2fb19b63226b19bbdedc4d08ae76540bacc
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ba06f2fb19b63226b19bbdedc4d08ae76540bacc

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Jan 30 14:53:45 2020 +0300

ole32: Fix a leak when creating pointer moniker through activation.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
(cherry picked from commit 157651a7846c227638ce9121d99ddf0af4722f41)
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>

---

 dlls/ole32/pointermoniker.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/ole32/pointermoniker.c b/dlls/ole32/pointermoniker.c
index a62ce3e7b7..453e131ee3 100644
--- a/dlls/ole32/pointermoniker.c
+++ b/dlls/ole32/pointermoniker.c
@@ -606,9 +606,7 @@ HRESULT WINAPI PointerMoniker_CreateInstance(IClassFactory *iface,
         return hr;
 
     hr = IMoniker_QueryInterface(pMoniker, riid, ppv);
-
-    if (FAILED(hr))
-        IMoniker_Release(pMoniker);
+    IMoniker_Release(pMoniker);
 
     return hr;
 }




More information about the wine-cvs mailing list