Zebediah Figura : d3dcompiler: Remove a redundant check for writemasks on non-numeric types.

Alexandre Julliard julliard at winehq.org
Fri Jun 5 14:16:51 CDT 2020


Module: wine
Branch: master
Commit: 24a4f52bbf7ac482c0f9129c1afdeccc8d319702
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=24a4f52bbf7ac482c0f9129c1afdeccc8d319702

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Wed Jun  3 21:06:51 2020 -0500

d3dcompiler: Remove a redundant check for writemasks on non-numeric types.

This can only happen if a swizzle is emitted on a non-numeric type, but this is
checked when emitting swizzles.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/d3dcompiler_43/utils.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/dlls/d3dcompiler_43/utils.c b/dlls/d3dcompiler_43/utils.c
index 7093e9eb2c..767d2dee50 100644
--- a/dlls/d3dcompiler_43/utils.c
+++ b/dlls/d3dcompiler_43/utils.c
@@ -1514,13 +1514,6 @@ struct hlsl_ir_node *make_assignment(struct hlsl_ir_node *lhs, enum parse_assign
         DWORD bitmask;
         enum hlsl_type_class type_class;
 
-        if (lhs->data_type->type > HLSL_CLASS_LAST_NUMERIC)
-        {
-            hlsl_report_message(lhs->loc, HLSL_LEVEL_ERROR,
-                    "writemask on a non scalar/vector/matrix type");
-            d3dcompiler_free(assign);
-            return NULL;
-        }
         bitmask = writemask & ((1 << lhs->data_type->dimx) - 1);
         while (bitmask)
         {




More information about the wine-cvs mailing list