Alistair Leslie-Hughes : xaudio2_7: Correct reference count on newly created XAudio2 object.

Alexandre Julliard julliard at winehq.org
Tue Mar 10 16:24:58 CDT 2020


Module: wine
Branch: master
Commit: 06549f53f9c58b18951f1229b9ec7e09134d5bb8
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=06549f53f9c58b18951f1229b9ec7e09134d5bb8

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Mon Mar  9 09:22:19 2020 +0000

xaudio2_7: Correct reference count on newly created XAudio2 object.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/xaudio2_7/xaudio_dll.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c
index a87e0124d3..fa0361182c 100644
--- a/dlls/xaudio2_7/xaudio_dll.c
+++ b/dlls/xaudio2_7/xaudio_dll.c
@@ -1955,10 +1955,8 @@ static HRESULT WINAPI XAudio2CF_CreateInstance(IClassFactory *iface, IUnknown *p
     FAudio_RegisterForCallbacks(object->faudio, &object->FAudioEngineCallback_vtbl);
 
     hr = IXAudio2_QueryInterface(&object->IXAudio2_iface, riid, ppobj);
+    IXAudio2_Release(&object->IXAudio2_iface);
     if(FAILED(hr)){
-        object->lock.DebugInfo->Spare[0] = 0;
-        DeleteCriticalSection(&object->lock);
-        HeapFree(GetProcessHeap(), 0, object);
         return hr;
     }
 




More information about the wine-cvs mailing list