Dmitry Timoshkov : adsldp: Implement IDirectorySearch::FreeColumn().

Alexandre Julliard julliard at winehq.org
Mon Mar 30 16:24:27 CDT 2020


Module: wine
Branch: master
Commit: 21959bf00a40c2daed3c47078d0181f17f2d3c77
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=21959bf00a40c2daed3c47078d0181f17f2d3c77

Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date:   Mon Mar 30 15:58:04 2020 +0800

adsldp: Implement IDirectorySearch::FreeColumn().

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/adsldp/adsldp.c     | 9 +++++++--
 dlls/adsldp/tests/ldap.c | 1 -
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/dlls/adsldp/adsldp.c b/dlls/adsldp/adsldp.c
index 8fe7bfd18c..61162f08a3 100644
--- a/dlls/adsldp/adsldp.c
+++ b/dlls/adsldp/adsldp.c
@@ -1446,8 +1446,13 @@ exit:
 
 static HRESULT WINAPI search_FreeColumn(IDirectorySearch *iface, PADS_SEARCH_COLUMN col)
 {
-    FIXME("%p,%p: stub\n", iface, col);
-    return E_NOTIMPL;
+    TRACE("%p,%p\n", iface, col);
+
+    if (!col) return E_ADS_BAD_PARAMETER;
+
+    heap_free(col->pADsValues);
+
+    return S_OK;
 }
 
 static HRESULT WINAPI search_CloseSearchHandle(IDirectorySearch *iface, ADS_SEARCH_HANDLE res)
diff --git a/dlls/adsldp/tests/ldap.c b/dlls/adsldp/tests/ldap.c
index bd22be8e61..3abbbdadb0 100644
--- a/dlls/adsldp/tests/ldap.c
+++ b/dlls/adsldp/tests/ldap.c
@@ -386,7 +386,6 @@ todo_wine
             }
 
             hr = IDirectorySearch_FreeColumn(ds, &col);
-todo_wine
             ok(hr == S_OK, "got %#x\n", hr);
         }
 




More information about the wine-cvs mailing list