Alexandre Julliard : ntdll: Fix off-by-one buffer size error.

Alexandre Julliard julliard at winehq.org
Wed May 27 15:19:30 CDT 2020


Module: wine
Branch: master
Commit: f5e703042ac6b10e803e7b796ffddabfdd82438c
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=f5e703042ac6b10e803e7b796ffddabfdd82438c

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Wed May 27 16:08:12 2020 +0200

ntdll: Fix off-by-one buffer size error.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49262
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntdll/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c
index 3c05c524af..fecb3673d4 100644
--- a/dlls/ntdll/loader.c
+++ b/dlls/ntdll/loader.c
@@ -2582,7 +2582,7 @@ static NTSTATUS find_builtin_dll( const WCHAR *name, WINE_MODREF **pwm,
 
     len = wcslen( name );
     if (build_dir) maxlen = strlen(build_dir) + sizeof("/programs/") + len;
-    maxlen = max( maxlen, dll_path_maxlen ) + len + sizeof(".so");
+    maxlen = max( maxlen, dll_path_maxlen + 1 ) + len + sizeof(".so");
 
     if (!(file = RtlAllocateHeap( GetProcessHeap(), 0, maxlen ))) return STATUS_NO_MEMORY;
 




More information about the wine-cvs mailing list