Sven Baars : d3dcompiler: Fix a leak on error path (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Oct 13 15:42:04 CDT 2020


Module: wine
Branch: master
Commit: 9f9fec18799bf59df6211b7294f8d338caa7f4db
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=9f9fec18799bf59df6211b7294f8d338caa7f4db

Author: Sven Baars <sbaars at codeweavers.com>
Date:   Sun Oct  4 22:39:11 2020 +0200

d3dcompiler: Fix a leak on error path (Coverity).

Signed-off-by: Sven Baars <sbaars at codeweavers.com>
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/d3dcompiler_43/utils.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3dcompiler_43/utils.c b/dlls/d3dcompiler_43/utils.c
index df39716b49..21ad98f2b5 100644
--- a/dlls/d3dcompiler_43/utils.c
+++ b/dlls/d3dcompiler_43/utils.c
@@ -1446,7 +1446,7 @@ static BOOL invert_swizzle(unsigned int *swizzle, unsigned int *writemask, unsig
 struct hlsl_ir_node *add_assignment(struct list *instrs, struct hlsl_ir_node *lhs,
         enum parse_assign_op assign_op, struct hlsl_ir_node *rhs)
 {
-    struct hlsl_ir_assignment *assign = d3dcompiler_alloc(sizeof(*assign));
+    struct hlsl_ir_assignment *assign;
     struct hlsl_type *lhs_type;
     DWORD writemask = 0;
 
@@ -1459,6 +1459,7 @@ struct hlsl_ir_node *add_assignment(struct list *instrs, struct hlsl_ir_node *lh
             return NULL;
     }
 
+    assign = d3dcompiler_alloc(sizeof(*assign));
     if (!assign)
     {
         ERR("Out of memory\n");




More information about the wine-cvs mailing list