Sven Baars : ntdll: Fix some memory leaks (Valgrind).
Alexandre Julliard
julliard at winehq.org
Mon Sep 21 15:12:15 CDT 2020
Module: wine
Branch: master
Commit: 123a4a884f343f76d40b843740c3c4290d5eca71
URL: https://source.winehq.org/git/wine.git/?a=commit;h=123a4a884f343f76d40b843740c3c4290d5eca71
Author: Sven Baars <sbaars at codeweavers.com>
Date: Sun Sep 20 18:25:27 2020 +0200
ntdll: Fix some memory leaks (Valgrind).
Signed-off-by: Sven Baars <sbaars at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/ntdll/unix/security.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/dlls/ntdll/unix/security.c b/dlls/ntdll/unix/security.c
index daecc5e059..09a1d787c0 100644
--- a/dlls/ntdll/unix/security.c
+++ b/dlls/ntdll/unix/security.c
@@ -779,8 +779,16 @@ NTSTATUS WINAPI NtSetSecurityObject( HANDLE handle, SECURITY_INFORMATION info, P
InitializeObjectAttributes( &attr, NULL, 0, 0, descr );
if ((status = alloc_object_attributes( &attr, &objattr, &len ))) return status;
sd = (struct security_descriptor *)(objattr + 1);
- if (info & OWNER_SECURITY_INFORMATION && !sd->owner_len) return STATUS_INVALID_SECURITY_DESCR;
- if (info & GROUP_SECURITY_INFORMATION && !sd->group_len) return STATUS_INVALID_SECURITY_DESCR;
+ if (info & OWNER_SECURITY_INFORMATION && !sd->owner_len)
+ {
+ free( objattr );
+ return STATUS_INVALID_SECURITY_DESCR;
+ }
+ if (info & GROUP_SECURITY_INFORMATION && !sd->group_len)
+ {
+ free( objattr );
+ return STATUS_INVALID_SECURITY_DESCR;
+ }
if (info & (SACL_SECURITY_INFORMATION | LABEL_SECURITY_INFORMATION)) sd->control |= SE_SACL_PRESENT;
if (info & DACL_SECURITY_INFORMATION) sd->control |= SE_DACL_PRESENT;
More information about the wine-cvs
mailing list