Alex Henrie : mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck).
Alexandre Julliard
julliard at winehq.org
Tue Dec 21 15:16:32 CST 2021
Module: wine
Branch: master
Commit: 06e0220ed6f4b842cf5903fc17d12bdad8e8f379
URL: https://source.winehq.org/git/wine.git/?a=commit;h=06e0220ed6f4b842cf5903fc17d12bdad8e8f379
Author: Alex Henrie <alexhenrie24 at gmail.com>
Date: Sun Dec 19 21:54:37 2021 -0700
mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck).
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/mshtml/omnavigator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c
index 70e8e568661..7788b453b8d 100644
--- a/dlls/mshtml/omnavigator.c
+++ b/dlls/mshtml/omnavigator.c
@@ -674,7 +674,7 @@ static HRESULT WINAPI OmHistory_get_length(IOmHistory *iface, short *p)
if(This->window && This->window->base.outer_window)
browser = This->window->base.outer_window->browser;
- *p = browser->doc->travel_log
+ *p = browser && browser->doc->travel_log
? ITravelLog_CountEntries(browser->doc->travel_log, browser->doc->browser_service)
: 0;
return S_OK;
More information about the wine-cvs
mailing list