Rémi Bernon : ntdll: Don't force submit wait in TpSetWait if timeout is 0.

Alexandre Julliard julliard at winehq.org
Thu Feb 11 15:37:15 CST 2021


Module: wine
Branch: master
Commit: 3ed3e031ffbbc3f80095e4d809ba1c55bd8e59f0
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=3ed3e031ffbbc3f80095e4d809ba1c55bd8e59f0

Author: Rémi Bernon <rbernon at codeweavers.com>
Date:   Thu Feb 11 10:53:47 2021 +0100

ntdll: Don't force submit wait in TpSetWait if timeout is 0.

It'll be submitted eventually, no need to force it and it makes support
for WT_EXECUTEINWAITTHREAD flag harder.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47843
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntdll/threadpool.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c
index db645118059..bef9a11905e 100644
--- a/dlls/ntdll/threadpool.c
+++ b/dlls/ntdll/threadpool.c
@@ -2941,7 +2941,6 @@ VOID WINAPI TpSetWait( TP_WAIT *wait, HANDLE handle, LARGE_INTEGER *timeout )
 {
     struct threadpool_object *this = impl_from_TP_WAIT( wait );
     ULONGLONG timestamp = TIMEOUT_INFINITE;
-    BOOL submit_wait = FALSE;
 
     TRACE( "%p %p %p\n", wait, handle, timeout );
 
@@ -2965,11 +2964,6 @@ VOID WINAPI TpSetWait( TP_WAIT *wait, HANDLE handle, LARGE_INTEGER *timeout )
                 NtQuerySystemTime( &now );
                 timestamp = now.QuadPart - timestamp;
             }
-            else if (!timestamp)
-            {
-                submit_wait = TRUE;
-                handle = NULL;
-            }
         }
 
         /* Add wait object back into one of the queues. */
@@ -2990,9 +2984,6 @@ VOID WINAPI TpSetWait( TP_WAIT *wait, HANDLE handle, LARGE_INTEGER *timeout )
     }
 
     RtlLeaveCriticalSection( &waitqueue.cs );
-
-    if (submit_wait)
-        tp_object_submit( this, FALSE );
 }
 
 /***********************************************************************




More information about the wine-cvs mailing list