Zebediah Figura : winegstreamer: Do not call gst_pad_event_default().

Alexandre Julliard julliard at winehq.org
Tue Jan 19 15:43:59 CST 2021


Module: wine
Branch: master
Commit: 6fdfacb5bf4e9b2c9f918b957d3da9f903514b25
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=6fdfacb5bf4e9b2c9f918b957d3da9f903514b25

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Mon Jan 18 21:57:18 2021 -0600

winegstreamer: Do not call gst_pad_event_default().

This matches the behaviour of GstBaseSrc and GstBaseSink. In particular, we
now return FALSE for unhandled source events.

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winegstreamer/gstdemux.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index f45036ae946..a10be5c6e2f 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -645,11 +645,13 @@ static gboolean event_src(GstPad *pad, GstObject *parent, GstEvent *event)
                 IAsyncReader_EndFlush(This->reader);
             LeaveCriticalSection(&This->filter.csFilter);
             break;
-        default:
-            WARN("Ignoring \"%s\" event.\n", GST_EVENT_TYPE_NAME(event));
         case GST_EVENT_QOS:
         case GST_EVENT_RECONFIGURE:
-            return gst_pad_event_default(pad, parent, event);
+            break;
+        default:
+            WARN("Ignoring \"%s\" event.\n", GST_EVENT_TYPE_NAME(event));
+            ret = FALSE;
+            break;
     }
     gst_event_unref(event);
     return ret;
@@ -729,7 +731,6 @@ static gboolean event_sink(GstPad *pad, GstObject *parent, GstEvent *event)
         }
         default:
             WARN("Ignoring \"%s\" event.\n", GST_EVENT_TYPE_NAME(event));
-            return gst_pad_event_default(pad, parent, event);
     }
     gst_event_unref(event);
     return TRUE;




More information about the wine-cvs mailing list