Jacek Caban : jscript: Support VARIANT type in jsval_strict_equal.

Alexandre Julliard julliard at winehq.org
Tue Jan 19 15:44:00 CST 2021


Module: wine
Branch: master
Commit: 7e4f254bbde8b7604375999ccd9aae5483139fff
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=7e4f254bbde8b7604375999ccd9aae5483139fff

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Tue Jan 19 14:34:03 2021 +0100

jscript: Support VARIANT type in jsval_strict_equal.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/jscript/engine.c      | 5 +++--
 dlls/jscript/tests/lang.js | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c
index 5635e3aa996..0fdcb13f142 100644
--- a/dlls/jscript/engine.c
+++ b/dlls/jscript/engine.c
@@ -522,8 +522,9 @@ HRESULT jsval_strict_equal(jsval_t lval, jsval_t rval, BOOL *ret)
         *ret = !get_bool(lval) == !get_bool(rval);
         break;
     case JSV_VARIANT:
-        FIXME("VARIANT not implemented\n");
-        return E_NOTIMPL;
+        WARN("VARIANT type, returning false\n");
+        *ret = FALSE;
+        return S_OK;
     }
 
     return S_OK;
diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js
index 7bcb121131e..6b3640bfa0b 100644
--- a/dlls/jscript/tests/lang.js
+++ b/dlls/jscript/tests/lang.js
@@ -201,6 +201,7 @@ ok(tmp === 3, "tmp = " + tmp);
     ok(getVT(d / d) === "VT_I4", "vt v_date(0) / v_date(0) = " + getVT(d / d));
     ok((+d) === e, "+v_date(0) = " + (+d) + " expected " + e);
     ok(("" + d).match(/^Sat Dec 30 00:00:00 .* 1899$/) != null, "+v_date(0) = " + d);
+    ok(d != d, "date d == d");
 
     d = v_date(2.5);
     e = Date.parse("Mon Jan 1 12:00:00 1900");
@@ -211,6 +212,7 @@ ok(tmp === 3, "tmp = " + tmp);
     e = Date.parse("Sat Mar 28 00:00:00 2015");
     ok((+d) === e, "+v_date(2015y) = " + (+d) + " expected " + e);
     ok(("" + d).match(/^Sat Mar 28 00:00:00 .* 2015$/) != null, "+v_date(2015y) = " + d);
+    ok(d != d, "date d == d");
 })();
 
 function testRecFunc(x) {




More information about the wine-cvs mailing list