Zebediah Figura : winegstreamer: Do not return GST_FLOW_NOT_LINKED if the DirectShow pin is not connected.

Alexandre Julliard julliard at winehq.org
Thu Jan 21 16:19:14 CST 2021


Module: wine
Branch: master
Commit: 36a7dd93d713ff16b0df6ef3cdb836d6614ec0f9
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=36a7dd93d713ff16b0df6ef3cdb836d6614ec0f9

Author: Zebediah Figura <z.figura12 at gmail.com>
Date:   Wed Jan 20 18:58:51 2021 -0600

winegstreamer: Do not return GST_FLOW_NOT_LINKED if the DirectShow pin is not connected.

This is a fatal error condition for GStreamer, but should not cause errors for
DirectShow.

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winegstreamer/gstdemux.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index 90ba02bba5d..da0121e089e 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -878,18 +878,12 @@ static GstFlowReturn got_data_sink(GstPad *pad, GstObject *parent, GstBuffer *bu
 
     TRACE("pad %p, pin %p, buffer %p.\n", pad, pin, buffer);
 
-    if (filter->initial)
+    if (filter->initial || !pin->pin.pin.peer)
     {
         gst_buffer_unref(buffer);
         return GST_FLOW_OK;
     }
 
-    if (!pin->pin.pin.peer)
-    {
-        gst_buffer_unref(buffer);
-        return GST_FLOW_NOT_LINKED;
-    }
-
     stream_event.type = PARSER_EVENT_BUFFER;
     stream_event.u.buffer = buffer;
     /* Transfer our reference to the buffer to the thread. */




More information about the wine-cvs mailing list