Zebediah Figura : msi: Return an error if trying to run a 64-bit custom action in a 32-bit prefix.
Alexandre Julliard
julliard at winehq.org
Mon Jan 25 16:42:06 CST 2021
Module: wine
Branch: master
Commit: 408662379281aa24f41b680f1aba9abf2b40c603
URL: https://source.winehq.org/git/wine.git/?a=commit;h=408662379281aa24f41b680f1aba9abf2b40c603
Author: Zebediah Figura <z.figura12 at gmail.com>
Date: Sat Jan 23 17:42:42 2021 -0600
msi: Return an error if trying to run a 64-bit custom action in a 32-bit prefix.
This matches native behaviour (manually tested).
This allows the Research in Motion (Blackberry) USB and Modem driver to fail
cleanly instead of hanging, if run in a 32-bit prefix.
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/msi/custom.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 7ae7e45af29..fb03958eb11 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -748,6 +748,13 @@ static msi_custom_action_info *do_msidbCustomActionTypeDll(
if (!ret)
info->arch = (sizeof(void *) == 8 ? SCS_64BIT_BINARY : SCS_32BIT_BINARY);
+ if (info->arch == SCS_64BIT_BINARY && sizeof(void *) == 4 && !is_wow64)
+ {
+ ERR("Attempt to run a 64-bit custom action inside a 32-bit WINEPREFIX.\n");
+ free_custom_action_data( info );
+ return NULL;
+ }
+
custom_start_server(package, info->arch);
info->handle = CreateThread(NULL, 0, custom_client_thread, info, 0, NULL);
More information about the wine-cvs
mailing list