Jan Sikorski : wined3d: Do not request device local memory if we also want it to be host visible.

Alexandre Julliard julliard at winehq.org
Thu Jul 29 16:37:52 CDT 2021


Module: wine
Branch: master
Commit: ad0b459ebe601e5e9f4de5ca0964cf9d4e94244a
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ad0b459ebe601e5e9f4de5ca0964cf9d4e94244a

Author: Jan Sikorski <jsikorski at codeweavers.com>
Date:   Thu Jul 29 13:52:26 2021 +0200

wined3d: Do not request device local memory if we also want it to be host visible.

Some implementations do not support this combination.

Signed-off-by: Jan Sikorski <jsikorski at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wined3d/buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c
index 4c5e2054fe0..4420885b15f 100644
--- a/dlls/wined3d/buffer.c
+++ b/dlls/wined3d/buffer.c
@@ -1410,12 +1410,12 @@ static BOOL wined3d_buffer_vk_create_buffer_object(struct wined3d_buffer_vk *buf
         FIXME("Ignoring some bind flags %#x.\n", bind_flags);
 
     memory_type = 0;
-    if (!(resource->usage & WINED3DUSAGE_DYNAMIC))
-        memory_type |= VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
     if (resource->access & WINED3D_RESOURCE_ACCESS_MAP_R)
         memory_type |= VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT;
     else if (resource->access & WINED3D_RESOURCE_ACCESS_MAP_W)
         memory_type |= VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
+    else if (!(resource->usage & WINED3DUSAGE_DYNAMIC))
+        memory_type |= VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
 
     if (!(wined3d_context_vk_create_bo(context_vk, resource->size, usage, memory_type, &buffer_vk->bo)))
     {




More information about the wine-cvs mailing list