Nikolay Sivov : msctf: Add ITextStoreACPServices::CreateRange().

Alexandre Julliard julliard at winehq.org
Wed Jun 2 16:27:43 CDT 2021


Module: wine
Branch: master
Commit: 759ecd6e593280b7dd0b84b4ab367be6f217888b
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=759ecd6e593280b7dd0b84b4ab367be6f217888b

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Jun  2 17:08:51 2021 +0300

msctf: Add ITextStoreACPServices::CreateRange().

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msctf/context.c              |  4 ++--
 dlls/msctf/tests/inputprocessor.c | 12 +++++-------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
index 9eb61efa411..e901cbcbee4 100644
--- a/dlls/msctf/context.c
+++ b/dlls/msctf/context.c
@@ -1022,9 +1022,9 @@ static HRESULT WINAPI TextStoreACPServices_CreateRange(ITextStoreACPServices *if
 {
     Context *This = impl_from_ITextStoreACPServices(iface);
 
-    FIXME("stub: %p %d %d %p\n", This, start, end, range);
+    TRACE("%p, %d, %d, %p.\n", This, start, end, range);
 
-    return S_OK;
+    return Range_Constructor(&This->ITfContext_iface, start, end, (ITfRange **)range);
 }
 
 static const ITextStoreACPServicesVtbl TextStoreACPServicesVtbl =
diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c
index 24362e9ef0a..67d1db1dbfb 100644
--- a/dlls/msctf/tests/inputprocessor.c
+++ b/dlls/msctf/tests/inputprocessor.c
@@ -249,13 +249,11 @@ static HRESULT WINAPI TextStoreACP_AdviseSink(ITextStoreACP *iface,
     range = NULL;
     hr = ITextStoreACPServices_CreateRange(services, 0, 1, &range);
     ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
-    if (range)
-    {
-        hr = ITfRangeACP_GetContext(range, &context);
-        ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
-        ITfContext_Release(context);
-        ITfRangeACP_Release(range);
-    }
+
+    hr = ITfRangeACP_GetContext(range, &context);
+    ok(hr == S_OK, "Unexpected hr %#x.\n", hr);
+    ITfContext_Release(context);
+    ITfRangeACP_Release(range);
 
     ITextStoreACPServices_Release(services);
 




More information about the wine-cvs mailing list