Haidong Yu : shell32: Fix a memory leak.

Alexandre Julliard julliard at winehq.org
Mon Jun 7 16:30:36 CDT 2021


Module: wine
Branch: master
Commit: 479b6594630c32b345aeb1cfd3c4c9cd8e214f95
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=479b6594630c32b345aeb1cfd3c4c9cd8e214f95

Author: Haidong Yu <yuhaidong at uniontech.com>
Date:   Mon Jun  7 17:47:33 2021 +0800

shell32: Fix a memory leak.

Signed-off-by: Haidong Yu <yuhaidong at uniontech.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/shell32/shelllink.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c
index 69d610f2503..2353ac3e56e 100644
--- a/dlls/shell32/shelllink.c
+++ b/dlls/shell32/shelllink.c
@@ -2158,7 +2158,10 @@ static HRESULT WINAPI IShellLinkW_fnSetPath(IShellLinkW * iface, LPCWSTR pszFile
         if (*pszFile == '\0')
             *buffer = '\0';
         else if (!GetFullPathNameW(pszFile, MAX_PATH, buffer, &fname))
-	    return E_FAIL;
+        {
+            heap_free(unquoted);
+            return E_FAIL;
+        }
         else if(!PathFileExistsW(buffer) &&
 		!SearchPathW(NULL, pszFile, NULL, MAX_PATH, buffer, NULL))
 	  hr = S_FALSE;




More information about the wine-cvs mailing list