Rémi Bernon : ntoskrnl.exe/tests: Silent a todo_wine failing test after a while.

Alexandre Julliard julliard at winehq.org
Wed Jun 9 16:43:05 CDT 2021


Module: wine
Branch: master
Commit: 4c81c50f449a5ead6cfebd8f1e284da407a2795b
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=4c81c50f449a5ead6cfebd8f1e284da407a2795b

Author: Rémi Bernon <rbernon at codeweavers.com>
Date:   Fri Jun  4 11:12:15 2021 +0200

ntoskrnl.exe/tests: Silent a todo_wine failing test after a while.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntoskrnl.exe/tests/driver_hid.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index 44ec1b09526..0f626e6866c 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -103,6 +103,7 @@ static const unsigned char report_descriptor[] =
 
 static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
 {
+    static BOOL test_failed;
     IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation(irp);
     const ULONG in_size = stack->Parameters.DeviceIoControl.InputBufferLength;
     const ULONG out_size = stack->Parameters.DeviceIoControl.OutputBufferLength;
@@ -175,11 +176,15 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
         }
 
         case IOCTL_HID_READ_REPORT:
+        {
+            ULONG expected_size = 2;
             ok(!in_size, "got input size %u\n", in_size);
-            todo_wine ok(out_size == 2, "got output size %u\n", out_size);
+            if (!test_failed) todo_wine ok(out_size == expected_size, "got output size %u\n", out_size);
+            if (out_size != expected_size) test_failed = TRUE;
 
             ret = STATUS_NOT_IMPLEMENTED;
             break;
+        }
 
         case IOCTL_HID_GET_STRING:
             ok(!in_size, "got input size %u\n", in_size);




More information about the wine-cvs mailing list