Francois Gouget : testbot/TestLauncher: Don't use an empty test unit name on skip lines.

Alexandre Julliard julliard at winehq.org
Tue Mar 16 16:32:08 CDT 2021


Module: tools
Branch: master
Commit: c791e0234404ad15821b1f4cb751904f41cf37bb
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=c791e0234404ad15821b1f4cb751904f41cf37bb

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Mar 16 12:14:18 2021 +0100

testbot/TestLauncher: Don't use an empty test unit name on skip lines.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/src/TestLauncher/TestLauncher.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/testbot/src/TestLauncher/TestLauncher.c b/testbot/src/TestLauncher/TestLauncher.c
index 5ff8060..dd34a76 100644
--- a/testbot/src/TestLauncher/TestLauncher.c
+++ b/testbot/src/TestLauncher/TestLauncher.c
@@ -109,7 +109,11 @@ BOOL CALLBACK DetectCriticalErrorDialog(HWND TopWnd, LPARAM lParam)
    if (Reason)
    {
       Skips++;
-      printf("%s.c:0: Tests skipped: %s (details below)\n", Subtest, Reason);
+      /* An empty test unit name is allowed on the start, summary and done
+       * lines, but not on individual failure / skip lines.
+       */
+      printf("%s.c:0: Tests skipped: %s (details below)\n",
+             (*Subtest ? Subtest : "testlauncher"), Reason);
       printf("| %s\n", Buffer);
       EnumChildWindows(TopWnd, DumpCriticalErrorDescription, (LPARAM)TopWnd);
       /* Leave the dialog open so it appears on screenshots */




More information about the wine-cvs mailing list