Vijay Kiran Kamuju : hnetcfg: Return S_OK in get_StaticPortMappingCollection.
Alexandre Julliard
julliard at winehq.org
Tue Mar 23 15:07:42 CDT 2021
Module: wine
Branch: oldstable
Commit: faa67872f71c69eb96803e4cd2c2803dd5467eff
URL: https://source.winehq.org/git/wine.git/?a=commit;h=faa67872f71c69eb96803e4cd2c2803dd5467eff
Author: Vijay Kiran Kamuju <infyquest at gmail.com>
Date: Sat Oct 10 12:44:44 2020 +0200
hnetcfg: Return S_OK in get_StaticPortMappingCollection.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49449
Signed-off-by: Vijay Kiran Kamuju <infyquest at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
(cherry picked from commit 5160c30fa75b631354586b528e3be2851a1909c4)
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
dlls/hnetcfg/port.c | 2 +-
dlls/hnetcfg/tests/policy.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/hnetcfg/port.c b/dlls/hnetcfg/port.c
index b0821d4b68c..fd4ac4977d3 100644
--- a/dlls/hnetcfg/port.c
+++ b/dlls/hnetcfg/port.c
@@ -720,7 +720,7 @@ static HRESULT WINAPI upnpnat_get_StaticPortMappingCollection(IUPnPNAT *iface, I
FIXME("%p, %p\n", This, collection);
if(collection)
*collection = NULL;
- return E_NOTIMPL;
+ return S_OK;
}
static HRESULT WINAPI upnpnat_get_DynamicPortMappingCollection(IUPnPNAT *iface, IDynamicPortMappingCollection **collection)
diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c
index 8701455841b..416049c0093 100644
--- a/dlls/hnetcfg/tests/policy.c
+++ b/dlls/hnetcfg/tests/policy.c
@@ -180,7 +180,7 @@ static void test_IUPnPNAT(void)
ok(hr == E_NOINTERFACE, "got: %08x\n", hr);
hr = IUPnPNAT_get_StaticPortMappingCollection(nat, &static_ports);
- todo_wine ok(hr == S_OK, "got: %08x\n", hr);
+ ok(hr == S_OK, "got: %08x\n", hr);
if(hr == S_OK && static_ports)
IStaticPortMappingCollection_Release(static_ports);
More information about the wine-cvs
mailing list