Anton Baskanov : quartz/dsoundrender: Defer EC_COMPLETE until running.
Alexandre Julliard
julliard at winehq.org
Thu May 27 16:02:10 CDT 2021
Module: wine
Branch: master
Commit: 4a9936e31896b8e529ca1c5ce2e6d31f29942e99
URL: https://source.winehq.org/git/wine.git/?a=commit;h=4a9936e31896b8e529ca1c5ce2e6d31f29942e99
Author: Anton Baskanov <baskanov at gmail.com>
Date: Wed May 26 23:46:45 2021 +0700
quartz/dsoundrender: Defer EC_COMPLETE until running.
Signed-off-by: Anton Baskanov <baskanov at gmail.com>
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/quartz/dsoundrender.c | 14 +++++++++++++-
dlls/quartz/tests/dsoundrender.c | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c
index 7c92eb6e6cc..68c88ea5a15 100644
--- a/dlls/quartz/dsoundrender.c
+++ b/dlls/quartz/dsoundrender.c
@@ -461,7 +461,8 @@ static HRESULT dsound_render_sink_eos(struct strmbase_sink *iface)
filter->eos = TRUE;
- if (graph && SUCCEEDED(IFilterGraph_QueryInterface(graph,
+ if (filter->filter.state == State_Running && graph
+ && SUCCEEDED(IFilterGraph_QueryInterface(graph,
&IID_IMediaEventSink, (void **)&event_sink)))
{
IMediaEventSink_Notify(event_sink, EC_COMPLETE, S_OK,
@@ -599,6 +600,8 @@ static HRESULT dsound_render_init_stream(struct strmbase_filter *iface)
static HRESULT dsound_render_start_stream(struct strmbase_filter *iface, REFERENCE_TIME start)
{
struct dsound_render *filter = impl_from_strmbase_filter(iface);
+ IFilterGraph *graph = filter->filter.graph;
+ IMediaEventSink *event_sink;
filter->stream_start = start;
@@ -607,6 +610,15 @@ static HRESULT dsound_render_start_stream(struct strmbase_filter *iface, REFEREN
if (filter->sink.pin.peer)
IDirectSoundBuffer_Play(filter->dsbuffer, 0, 0, DSBPLAY_LOOPING);
+ if (filter->eos && graph
+ && SUCCEEDED(IFilterGraph_QueryInterface(graph,
+ &IID_IMediaEventSink, (void **)&event_sink)))
+ {
+ IMediaEventSink_Notify(event_sink, EC_COMPLETE, S_OK,
+ (LONG_PTR)&filter->filter.IBaseFilter_iface);
+ IMediaEventSink_Release(event_sink);
+ }
+
return S_OK;
}
diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c
index 87c3706b145..fdc23d2b48c 100644
--- a/dlls/quartz/tests/dsoundrender.c
+++ b/dlls/quartz/tests/dsoundrender.c
@@ -920,7 +920,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IMediaControl *control)
hr = IMediaControl_GetState(control, 1000, &state);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ret = check_ec_complete(eventsrc, 0);
- todo_wine ok(!ret, "Got unexpected EC_COMPLETE.\n");
+ ok(!ret, "Got unexpected EC_COMPLETE.\n");
hr = send_frame(input);
todo_wine ok(hr == VFW_E_SAMPLE_REJECTED_EOS, "Got hr %#x.\n", hr);
@@ -928,7 +928,7 @@ static void test_eos(IPin *pin, IMemInputPin *input, IMediaControl *control)
hr = IMediaControl_Run(control);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ret = check_ec_complete(eventsrc, 0);
- todo_wine ok(ret == 1, "Expected EC_COMPLETE.\n");
+ ok(ret == 1, "Expected EC_COMPLETE.\n");
hr = IMediaControl_Stop(control);
ok(hr == S_OK, "Got hr %#x.\n", hr);
More information about the wine-cvs
mailing list