Rémi Bernon : dinput: Prevent a device interface leak when enumerating.
Alexandre Julliard
julliard at winehq.org
Mon May 31 15:58:36 CDT 2021
Module: wine
Branch: master
Commit: 52aacd2377c68097ea165fdfff188fd6768fcc4c
URL: https://source.winehq.org/git/wine.git/?a=commit;h=52aacd2377c68097ea165fdfff188fd6768fcc4c
Author: Rémi Bernon <rbernon at codeweavers.com>
Date: Mon May 31 10:23:57 2021 +0200
dinput: Prevent a device interface leak when enumerating.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=36263
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/dinput/dinput_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c
index 62e70e0535c..c7b932aca44 100644
--- a/dlls/dinput/dinput_main.c
+++ b/dlls/dinput/dinput_main.c
@@ -864,8 +864,10 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics(
if (lpCallback(&didevis[i], lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
{
HeapFree(GetProcessHeap(), 0, didevis);
+ IDirectInputDevice_Release(lpdid);
return DI_OK;
}
+ IDirectInputDevice_Release(lpdid);
}
HeapFree(GetProcessHeap(), 0, didevis);
@@ -883,7 +885,11 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics(
IDirectInputDevice_GetDeviceInfo(lpdid, &didevi);
if (lpCallback(&didevi, lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP)
+ {
+ IDirectInputDevice_Release(lpdid);
return DI_OK;
+ }
+ IDirectInputDevice_Release(lpdid);
}
}
More information about the wine-cvs
mailing list