Gabriel Ivăncescu : mshtml: Fix reference leak in HTMLStyleSheetRulesCollection_item.

Alexandre Julliard julliard at winehq.org
Mon Nov 1 16:38:03 CDT 2021


Module: wine
Branch: master
Commit: 9ca56d3e97160fa428131258f87ff8df39116d5f
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=9ca56d3e97160fa428131258f87ff8df39116d5f

Author: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Date:   Mon Oct 25 16:30:29 2021 +0300

mshtml: Fix reference leak in HTMLStyleSheetRulesCollection_item.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/htmlstylesheet.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/htmlstylesheet.c b/dlls/mshtml/htmlstylesheet.c
index 52eaa214508..c31c7809f63 100644
--- a/dlls/mshtml/htmlstylesheet.c
+++ b/dlls/mshtml/htmlstylesheet.c
@@ -348,6 +348,7 @@ static HRESULT WINAPI HTMLStyleSheetRulesCollection_item(IHTMLStyleSheetRulesCol
     HTMLStyleSheetRulesCollection *This = impl_from_IHTMLStyleSheetRulesCollection(iface);
     nsIDOMCSSRule *nsstylesheetrule;
     nsresult nsres;
+    HRESULT hres;
 
     TRACE("(%p)->(%d %p)\n", This, index, p);
 
@@ -357,7 +358,9 @@ static HRESULT WINAPI HTMLStyleSheetRulesCollection_item(IHTMLStyleSheetRulesCol
     if(!nsstylesheetrule)
         return E_INVALIDARG;
 
-    return create_style_sheet_rule(nsstylesheetrule, dispex_compat_mode(&This->dispex), p);
+    hres = create_style_sheet_rule(nsstylesheetrule, dispex_compat_mode(&This->dispex), p);
+    nsIDOMCSSRule_Release(nsstylesheetrule);
+    return hres;
 }
 
 static const IHTMLStyleSheetRulesCollectionVtbl HTMLStyleSheetRulesCollectionVtbl = {




More information about the wine-cvs mailing list