Zebediah Figura : quartz/dsoundrender: Send EC_COMPLETE in IBaseFilter::Run() when not connected.

Alexandre Julliard julliard at winehq.org
Mon Nov 1 16:38:03 CDT 2021


Module: wine
Branch: master
Commit: 0b79e2caa6f224fc0da672886c07f4f32dda4682
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=0b79e2caa6f224fc0da672886c07f4f32dda4682

Author: Zebediah Figura <zfigura at codeweavers.com>
Date:   Sun Oct 31 19:04:09 2021 -0500

quartz/dsoundrender: Send EC_COMPLETE in IBaseFilter::Run() when not connected.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/quartz/dsoundrender.c       | 2 +-
 dlls/quartz/tests/dsoundrender.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c
index 51a66ac5d30..df40d1254ee 100644
--- a/dlls/quartz/dsoundrender.c
+++ b/dlls/quartz/dsoundrender.c
@@ -608,7 +608,7 @@ static HRESULT dsound_render_start_stream(struct strmbase_filter *iface, REFEREN
     if (filter->sink.pin.peer)
         IDirectSoundBuffer_Play(filter->dsbuffer, 0, 0, DSBPLAY_LOOPING);
 
-    if (filter->eos && graph
+    if ((filter->eos || !filter->sink.pin.peer) && graph
             && SUCCEEDED(IFilterGraph_QueryInterface(graph,
             &IID_IMediaEventSink, (void **)&event_sink)))
     {
diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c
index 9107828b9df..03e6b8413d5 100644
--- a/dlls/quartz/tests/dsoundrender.c
+++ b/dlls/quartz/tests/dsoundrender.c
@@ -1355,7 +1355,7 @@ static void test_unconnected_eos(void)
     ok(hr == S_OK, "Got hr %#x.\n", hr);
 
     ret = check_ec_complete(eventsrc, 0);
-    todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
+    ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
 
     hr = IMediaControl_Pause(control);
     ok(hr == S_OK, "Got hr %#x.\n", hr);
@@ -1367,7 +1367,7 @@ static void test_unconnected_eos(void)
     ok(hr == S_OK, "Got hr %#x.\n", hr);
 
     ret = check_ec_complete(eventsrc, 0);
-    todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
+    ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
 
     hr = IMediaControl_Stop(control);
     ok(hr == S_OK, "Got hr %#x.\n", hr);
@@ -1379,7 +1379,7 @@ static void test_unconnected_eos(void)
     ok(hr == S_OK, "Got hr %#x.\n", hr);
 
     ret = check_ec_complete(eventsrc, 0);
-    todo_wine ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
+    ok(ret == 1, "Got %u EC_COMPLETE events.\n", ret);
 
     IMediaControl_Release(control);
     IMediaEvent_Release(eventsrc);




More information about the wine-cvs mailing list