André Zwing : ucrtbase/tests: Don't test functions directly when reporting GetLastError().

Alexandre Julliard julliard at winehq.org
Mon Nov 22 16:05:17 CST 2021


Module: wine
Branch: master
Commit: 191a67d3bf148891904c0be3dd3d8acdeca73206
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=191a67d3bf148891904c0be3dd3d8acdeca73206

Author: André Zwing <nerv at dawncrow.de>
Date:   Sun Nov 21 18:05:29 2021 +0100

ucrtbase/tests: Don't test functions directly when reporting GetLastError().

Signed-off-by: André Zwing <nerv at dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ucrtbase/tests/thread.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/ucrtbase/tests/thread.c b/dlls/ucrtbase/tests/thread.c
index 7693304e612..940db8e4dbf 100644
--- a/dlls/ucrtbase/tests/thread.c
+++ b/dlls/ucrtbase/tests/thread.c
@@ -105,7 +105,8 @@ static void test_thread_library_reference(char *thread_dll,
 
     ok(thread_handle != -1 && thread_handle != 0, "Failed to begin thread: %u\n", errno);
 
-    ok(FreeLibrary(dll), "Failed to free the library: %u\n", GetLastError());
+    ret = FreeLibrary(dll);
+    ok(ret, "Failed to free the library: %u\n", GetLastError());
 
     ret = WaitForSingleObject(args.confirm_running, 200);
     ok(ret == WAIT_OBJECT_0, "Event was not signaled, ret: %u, err: %u\n", ret, GetLastError());
@@ -113,7 +114,8 @@ static void test_thread_library_reference(char *thread_dll,
     ret = WaitForSingleObject(detach_event, 0);
     ok(ret == WAIT_TIMEOUT, "Thread detach happened unexpectedly signaling an event, ret: %d, err: %u\n", ret, GetLastError());
 
-    ok(SetEvent(args.past_free), "Failed to signal event: %d\n", GetLastError());
+    ret = SetEvent(args.past_free);
+    ok(ret, "Failed to signal event: %d\n", GetLastError());
 
     if (beginthread_method == use_beginthreadex)
     {




More information about the wine-cvs mailing list