Gabriel Ivăncescu : mshtml: Implement HTMLElementCollection's toString.
Alexandre Julliard
julliard at winehq.org
Thu Oct 7 16:21:23 CDT 2021
Module: wine
Branch: master
Commit: f8c963426247eb3fa9219edebf0f9c900405d1b1
URL: https://source.winehq.org/git/wine.git/?a=commit;h=f8c963426247eb3fa9219edebf0f9c900405d1b1
Author: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Date: Thu Oct 7 16:52:33 2021 +0300
mshtml: Implement HTMLElementCollection's toString.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/mshtml/htmlelemcol.c | 6 ++++--
dlls/mshtml/tests/documentmode.js | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/dlls/mshtml/htmlelemcol.c b/dlls/mshtml/htmlelemcol.c
index 86ef3a32639..895b3db5b2a 100644
--- a/dlls/mshtml/htmlelemcol.c
+++ b/dlls/mshtml/htmlelemcol.c
@@ -301,8 +301,10 @@ static HRESULT WINAPI HTMLElementCollection_toString(IHTMLElementCollection *ifa
BSTR *String)
{
HTMLElementCollection *This = impl_from_IHTMLElementCollection(iface);
- FIXME("(%p)->(%p)\n", This, String);
- return E_NOTIMPL;
+
+ TRACE("(%p)->(%p)\n", This, String);
+
+ return dispex_to_string(&This->dispex, String);
}
static HRESULT WINAPI HTMLElementCollection_put_length(IHTMLElementCollection *iface,
diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js
index a392ae43274..cf0d7bf0f4b 100644
--- a/dlls/mshtml/tests/documentmode.js
+++ b/dlls/mshtml/tests/documentmode.js
@@ -210,6 +210,7 @@ sync_test("builtin_toString", function() {
if(clientRects) test("clientRect", clientRects[0], "ClientRect");
if(clientRects) test("clientRects", clientRects, "ClientRectList");
if(currentStyle) test("currentStyle", currentStyle, "MSCurrentStyleCSSProperties");
+ test("elements", document.getElementsByTagName("body"), "HTMLCollection");
test("history", window.history, "History");
test("implementation", document.implementation, "DOMImplementation");
if(localStorage) test("localStorage", localStorage, "Storage");
More information about the wine-cvs
mailing list