Robert Wilhelm : vbscript: Don't use function return value for call expressions.
Alexandre Julliard
julliard at winehq.org
Fri Oct 8 14:12:27 CDT 2021
Module: wine
Branch: master
Commit: 4f5e5cc63f5fa40d198c3cae60633d7de0c03bc0
URL: https://source.winehq.org/git/wine.git/?a=commit;h=4f5e5cc63f5fa40d198c3cae60633d7de0c03bc0
Author: Robert Wilhelm <robert.wilhelm at gmx.net>
Date: Fri Oct 8 19:14:09 2021 +0200
vbscript: Don't use function return value for call expressions.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50758
Signed-off-by: Robert Wilhelm <robert.wilhelm at gmx.net>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/vbscript/interp.c | 10 +++++++++-
dlls/vbscript/tests/lang.vbs | 24 ++++++++++++++++++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/dlls/vbscript/interp.c b/dlls/vbscript/interp.c
index e2c1d5cc53d..48863068013 100644
--- a/dlls/vbscript/interp.c
+++ b/dlls/vbscript/interp.c
@@ -134,7 +134,8 @@ static HRESULT lookup_identifier(exec_ctx_t *ctx, BSTR name, vbdisp_invoke_type_
DISPID id;
HRESULT hres;
- if((ctx->func->type == FUNC_FUNCTION || ctx->func->type == FUNC_PROPGET)
+ if(invoke_type != VBDISP_CALLGET
+ && (ctx->func->type == FUNC_FUNCTION || ctx->func->type == FUNC_PROPGET)
&& !wcsicmp(name, ctx->func->name)) {
ref->type = REF_VAR;
ref->u.v = &ctx->ret_val;
@@ -800,6 +801,13 @@ static HRESULT interp_ident(exec_ctx_t *ctx)
TRACE("%s\n", debugstr_w(identifier));
+ if((ctx->func->type == FUNC_FUNCTION || ctx->func->type == FUNC_PROPGET)
+ && !wcsicmp(identifier, ctx->func->name)) {
+ V_VT(&v) = VT_BYREF|VT_VARIANT;
+ V_BYREF(&v) = &ctx->ret_val;
+ return stack_push(ctx, &v);
+ }
+
hres = do_icall(ctx, &v, identifier, 0);
if(FAILED(hres))
return hres;
diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs
index d7865301784..dc2acbae69c 100644
--- a/dlls/vbscript/tests/lang.vbs
+++ b/dlls/vbscript/tests/lang.vbs
@@ -1882,6 +1882,30 @@ set arr(0) = new TestPropSyntax
arr(0).prop = 1
ok arr(0).prop = 1, "arr(0) = " & arr(0).prop
+function recursingfunction(x)
+ if (x) then exit function
+ recursingfunction = 2
+ dim y
+ y = recursingfunction
+ call ok(y = 2, "y = " & y)
+ recursingfunction = 1
+ call recursingfunction(True)
+end function
+call ok(recursingfunction(False) = 1, "unexpected return value " & recursingfunction(False))
+
+x = false
+function recursingfunction2
+ if (x) then exit function
+ recursingfunction2 = 2
+ dim y
+ y = recursingfunction2
+ call ok(y = 2, "y = " & y)
+ recursingfunction2 = 1
+ x = true
+ recursingfunction2()
+end function
+call ok(recursingfunction2() = 1, "unexpected return value " & recursingfunction2())
+
function f2(x,y)
end function
More information about the wine-cvs
mailing list