Rémi Bernon : joy.cpl: Better handle effect creation errors.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 960bb3694143bfd4130229bc7ba7e3d315afa084
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=960bb3694143bfd4130229bc7ba7e3d315afa084

Author: Rémi Bernon <rbernon at codeweavers.com>
Date:   Thu Oct 14 09:39:55 2021 +0200

joy.cpl: Better handle effect creation errors.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51873
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/joy.cpl/main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c
index 4431669eee8..c96efb17aa3 100644
--- a/dlls/joy.cpl/main.c
+++ b/dlls/joy.cpl/main.c
@@ -867,6 +867,11 @@ static BOOL CALLBACK ff_effects_callback(const DIEFFECTINFOW *pdei, void *pvRef)
 
     hr = IDirectInputDevice2_CreateEffect(
         joystick->device, &pdei->guid, &dieffect, &joystick->effects[joystick->cur_effect].effect, NULL);
+    if (FAILED(hr))
+    {
+        FIXME("Failed to create effect with type %s, hr %#x\n", debugstr_guid(&pdei->guid), hr);
+        return DIENUM_CONTINUE;
+    }
 
     joystick->effects[joystick->cur_effect].params = dieffect;
     joystick->effects[joystick->cur_effect].info = *pdei;