Eric Pouech : dbghelp: Add internal_line_t structure as help in Line manipulation.

Alexandre Julliard julliard at winehq.org
Tue Sep 7 16:25:21 CDT 2021


Module: wine
Branch: master
Commit: fabc4f7e124a50a22da258987d8ca410203e90d8
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=fabc4f7e124a50a22da258987d8ca410203e90d8

Author: Eric Pouech <eric.pouech at gmail.com>
Date:   Tue Sep  7 09:26:43 2021 +0200

dbghelp: Add internal_line_t structure as help in Line manipulation.

the rationale is that:
- the file name in IMAGEHLP_LINE* structures is returned as a pointer to
  an internal buffer
- in the W64 variant of APIs, two calls to fetch_buffer() are currently needed
  (one for first A allocation, second for W conversion)
- this generate bugs as it's assumed the two buffers are different

so the internal_line_t purpose is to factorize the implementations
of the 3 variants (A32, A64, W64) into a single code path
this insures a unique allocation, and at most, one conversion

Signed-off-by: Eric Pouech <eric.pouech at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/dbghelp/symbol.c | 206 +++++++++++++++++++++++++++++++++++---------------
 1 file changed, 146 insertions(+), 60 deletions(-)

Diff:   https://source.winehq.org/git/wine.git/?a=commitdiff;h=fabc4f7e124a50a22da258987d8ca410203e90d8



More information about the wine-cvs mailing list