Tim Clem : winemac.drv: Remove now-unnecessary drag stop event on mouse up.

Alexandre Julliard julliard at winehq.org
Wed Sep 15 16:21:29 CDT 2021


Module: wine
Branch: master
Commit: a45bb014e884a59a2109fa4602e8b22a7a8e7e89
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=a45bb014e884a59a2109fa4602e8b22a7a8e7e89

Author: Tim Clem <tclem at codeweavers.com>
Date:   Tue Sep 14 13:22:46 2021 -0700

winemac.drv: Remove now-unnecessary drag stop event on mouse up.

This approach was added by 5cf64084fb6 to work around changes to
event behavior in macOS Catalina, 10.15. However, more reliable
notification center messages for dragging are available on 10.12+,
making this path unnecessary.

Signed-off-by: Tim Clem <tclem at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winemac.drv/cocoa_app.m | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m
index fe10ee8c41d..2d18da7f99a 100644
--- a/dlls/winemac.drv/cocoa_app.m
+++ b/dlls/winemac.drv/cocoa_app.m
@@ -1747,14 +1747,6 @@ static NSString* WineLocalizedString(unsigned int stringID)
         WineWindow* windowBroughtForward = nil;
         BOOL process = FALSE;
 
-        if (!useDragNotifications &&
-            type == NSEventTypeLeftMouseUp &&
-            [windowsBeingDragged count] &&
-            [window isKindOfClass:[WineWindow class]])
-        {
-            [self handleWindowDrag:window begin:NO];
-        }
-
         if ([window isKindOfClass:[WineWindow class]] &&
             type == NSEventTypeLeftMouseDown &&
             ![theEvent wine_commandKeyDown])




More information about the wine-cvs mailing list