Nikolay Sivov : inetcpl: Fix incorrect expression (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Sep 15 16:21:31 CDT 2021


Module: wine
Branch: master
Commit: fec56bb4570ce50d3c4746fa3fc30511973fc12c
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=fec56bb4570ce50d3c4746fa3fc30511973fc12c

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Sep 15 13:25:06 2021 +0300

inetcpl: Fix incorrect expression (Coverity).

This is a regression from a65616cf1fcf404090199b82e6d01e0f08e0d4ea,
search-replace gone wrong because global literal constant had the same
name as the helper argument.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/inetcpl.cpl/connections.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/inetcpl.cpl/connections.c b/dlls/inetcpl.cpl/connections.c
index 4327c33b420..d33c0bf3a19 100644
--- a/dlls/inetcpl.cpl/connections.c
+++ b/dlls/inetcpl.cpl/connections.c
@@ -62,7 +62,7 @@ static DWORD create_connection_settings(BOOL manual_proxy, const WCHAR *proxy_se
     DWORD pac_url_len;
 
     size += sizeof(DWORD);
-    if(L"ProxyServer")
+    if(proxy_server)
     {
         proxy_server_len = WideCharToMultiByte(CP_UTF8, 0, proxy_server, -1,
                 NULL, 0, NULL, NULL);




More information about the wine-cvs mailing list