Zebediah Figura : Revert "winegstreamer: Replace source pad interface with GstAppSrc.".

Alexandre Julliard julliard at winehq.org
Fri Sep 24 15:31:59 CDT 2021


Module: wine
Branch: master
Commit: 176654fa29d1ff46011eaa65e1da5fb22a155bb3
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=176654fa29d1ff46011eaa65e1da5fb22a155bb3

Author: Zebediah Figura <zfigura at codeweavers.com>
Date:   Thu Sep 23 23:10:28 2021 -0500

Revert "winegstreamer: Replace source pad interface with GstAppSrc.".

This reverts commit 1aa359a100bae859b278007e8bf90673eebd7db0.

appsrc suffers from a rather problematic race condition surrounding flushes [1].
Essentially, it's possible for a flushing seek to begin and end between
wg_parser_get_next_read_request and wg_parser_push_data. The race condition is
not easy to fix, and in light of it it's not clear if we want to use appsrc.

[1] https://www.winehq.org/pipermail/wine-devel/2021-September/196043.html

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51774
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winegstreamer/wg_parser.c | 425 +++++++++++++++++++++++++++++------------
 1 file changed, 308 insertions(+), 117 deletions(-)

Diff:   https://source.winehq.org/git/wine.git/?a=commitdiff;h=176654fa29d1ff46011eaa65e1da5fb22a155bb3



More information about the wine-cvs mailing list