Francois Gouget : testbot: The last GetTaskURL() parameter is in fact a log name.
Alexandre Julliard
julliard at winehq.org
Mon Apr 4 15:32:47 CDT 2022
Module: tools
Branch: master
Commit: a332ac13efd3a29bf305dc2048992a95b1233567
URL: https://source.winehq.org/git/tools.git/?a=commit;h=a332ac13efd3a29bf305dc2048992a95b1233567
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Mon Apr 4 18:14:25 2022 +0200
testbot: The last GetTaskURL() parameter is in fact a log name.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
testbot/lib/WineTestBot/Utils.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testbot/lib/WineTestBot/Utils.pm b/testbot/lib/WineTestBot/Utils.pm
index d93a938..13529c3 100644
--- a/testbot/lib/WineTestBot/Utils.pm
+++ b/testbot/lib/WineTestBot/Utils.pm
@@ -34,6 +34,7 @@ our @EXPORT = qw(SecureConnection MakeSecureURL GetTaskURL GenerateRandomString
BatchQuote ShQuote ShArgv2Cmd);
use Fcntl qw(O_CREAT O_EXCL O_WRONLY);
+use URI::Escape;
use WineTestBot::Config;
@@ -84,11 +85,11 @@ sub MakeSecureURL($)
sub GetTaskURL($$$;$$)
{
- my ($JobId, $StepNo, $TaskNo, $ShowScreenshot, $ShowLog) = @_;
+ my ($JobId, $StepNo, $TaskNo, $ShowScreenshot, $LogName) = @_;
my $StepTask = 100 * $StepNo + $TaskNo;
my $URL = "/JobDetails.pl?Key=$JobId";
$URL .= "&s$StepTask=1" if ($ShowScreenshot);
- $URL .= "&f$StepTask=$ShowLog" if ($ShowLog);
+ $URL .= "&f$StepTask=". uri_escape($LogName) if ($LogName);
return "$URL#k$StepTask";
}
More information about the wine-cvs
mailing list