Francois Gouget : testbot/cgi: Clean up CollectionBlock's property handling.

Alexandre Julliard julliard at winehq.org
Thu Apr 14 16:39:55 CDT 2022


Module: tools
Branch: master
Commit: 1f0e5a654d1e59678d093f81a77d3b281743d210
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=1f0e5a654d1e59678d093f81a77d3b281743d210

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Apr 14 16:58:04 2022 +0200

testbot/cgi: Clean up CollectionBlock's property handling.

Delegate generating the inside of a cell to GenerateDataView() such that
GenerateDataCell() only deals with the cell itself.
Remove GetDisplayValue() and GetEscapedDisplayValue(): CollectionBlocks
don't deal with editing so there is no need for access to the 'raw'
data. Thus they are both replaced by GenerateDataView().

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 251 +++++++++++++++----------
 testbot/web/JobDetails.pl                      |  36 ++--
 testbot/web/PatchesList.pl                     |  14 +-
 testbot/web/WineTestBot.css                    |   4 +-
 testbot/web/admin/UsersList.pl                 |  14 +-
 testbot/web/index.pl                           |  58 +++---
 6 files changed, 210 insertions(+), 167 deletions(-)

Diff:   https://source.winehq.org/git/tools.git/?a=commitdiff;h=1f0e5a654d1e59678d093f81a77d3b281743d210



More information about the wine-cvs mailing list