Francois Gouget : testbot/web: Simplify linking patches to the job details pages.

Alexandre Julliard julliard at winehq.org
Mon Apr 18 15:53:32 CDT 2022


Module: tools
Branch: master
Commit: 74981370d37c7951ed15268d7d069a62c1520adf
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=74981370d37c7951ed15268d7d069a62c1520adf

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Apr 18 10:55:05 2022 +0200

testbot/web: Simplify linking patches to the job details pages.

There is no need to call uri_escape() on integers.
Also the URL is simple (no ampersand) and does not need to go through
escapeHTML().

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/PatchesList.pl | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/testbot/web/PatchesList.pl b/testbot/web/PatchesList.pl
index 943b9c5..48c8382 100644
--- a/testbot/web/PatchesList.pl
+++ b/testbot/web/PatchesList.pl
@@ -25,7 +25,6 @@ package PatchesBlock;
 use ObjectModel::CGI::CollectionBlock;
 our @ISA = qw(ObjectModel::CGI::CollectionBlock);
 
-use URI::Escape;
 use WineTestBot::Patches;
 
 
@@ -54,9 +53,7 @@ sub GenerateDataView($$$)
       $Row->{Item}->Disposition =~ /job ([0-9]+)$/)
   {
     my $JobId = $1;
-    my $URI = "/JobDetails.pl?Key=" . uri_escape($JobId);
-    print "<a href='" . $self->escapeHTML($URI) . "'>" .
-          "Job " . $self->escapeHTML($JobId) . "</a>";
+    print "<a href='/JobDetails.pl?Key=$JobId'>Job $JobId</a>";
   }
   else
   {




More information about the wine-cvs mailing list