Francois Gouget : testbot/web: Use GenerateDataView() for the users list.

Alexandre Julliard julliard at winehq.org
Wed Apr 20 16:33:32 CDT 2022


Module: tools
Branch: master
Commit: aee314fddcdda8d6c2f5ef2cdb30ded744fdd8d6
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=aee314fddcdda8d6c2f5ef2cdb30ded744fdd8d6

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Apr 20 16:16:12 2022 +0200

testbot/web: Use GenerateDataView() for the users list.

There is no need to override GenerateDataCell().

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/admin/UsersList.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/web/admin/UsersList.pl b/testbot/web/admin/UsersList.pl
index 368a6ce..dcdb811 100644
--- a/testbot/web/admin/UsersList.pl
+++ b/testbot/web/admin/UsersList.pl
@@ -45,7 +45,7 @@ sub DisplayProperty($$)
   return $PropertyName =~ /^(?:Name|EMail|Status|RealName)$/ ? "ro" : "";
 }
 
-sub GenerateDataCell($$$)
+sub GenerateDataView($$$)
 {
   my ($self, $Row, $PropertyDescriptor) = @_;
 
@@ -83,11 +83,11 @@ sub GenerateDataCell($$$)
       ($Class, $Label) = ('usernone', 'none');
     }
     my $DetailsLink = $self->GetDetailsLink($Row);
-    print "<td><a href='$DetailsLink'><span class='$Class'>$Label</span></a></td>";
+    print "<a href='$DetailsLink'><span class='$Class'>$Label</span></a>";
   }
   else
   {
-    $self->SUPER::GenerateDataCell($Row, $PropertyDescriptor);
+    $self->SUPER::GenerateDataView($Row, $PropertyDescriptor);
   }
 }
 




More information about the wine-cvs mailing list