Zebediah Figura : winhttp: Don't make a copy of the string in add_request_headers().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 7cd30faabee03ffc982b6e1ff2c0be9aa75c2418
URL:    https://gitlab.winehq.org/wine/wine/-/commit/7cd30faabee03ffc982b6e1ff2c0be9aa75c2418

Author: Zebediah Figura <zfigura at codeweavers.com>
Date:   Tue Aug  9 18:23:56 2022 -0500

winhttp: Don't make a copy of the string in add_request_headers().

---

 dlls/winhttp/request.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c
index e846676041e..9f769f3dc35 100644
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -455,23 +455,20 @@ DWORD process_header( struct request *request, const WCHAR *field, const WCHAR *
 DWORD add_request_headers( struct request *request, const WCHAR *headers, DWORD len, DWORD flags )
 {
     DWORD ret = ERROR_WINHTTP_INVALID_HEADER;
-    WCHAR *buffer, *p, *q;
     struct header *header;
+    const WCHAR *p, *q;
 
     if (len == ~0u) len = lstrlenW( headers );
     if (!len) return ERROR_SUCCESS;
-    if (!(buffer = malloc( (len + 1) * sizeof(WCHAR) ))) return ERROR_OUTOFMEMORY;
-    memcpy( buffer, headers, len * sizeof(WCHAR) );
-    buffer[len] = 0;
 
-    p = buffer;
+    p = headers;
     do
     {
         const WCHAR *end;
 
-        if (!*p) break;
+        if (p >= headers + len) break;
 
-        for (q = p; *q && *q != '\r' && *q != '\n'; ++q)
+        for (q = p; q < headers + len && *q != '\r' && *q != '\n'; ++q)
             ;
         end = q;
         while (*q == '\r' || *q == '\n')
@@ -485,7 +482,6 @@ DWORD add_request_headers( struct request *request, const WCHAR *headers, DWORD
         p = q;
     } while (!ret);
 
-    free( buffer );
     return ret;
 }