Robert Wilhelm : wshom: Use signed type for property ExitCode in IWshExec.

Alexandre Julliard julliard at winehq.org
Mon Aug 15 15:22:31 CDT 2022


Module: wine
Branch: master
Commit: e7dada5f9050fb265d314c841f8ce4b45415141a
URL:    https://gitlab.winehq.org/wine/wine/-/commit/e7dada5f9050fb265d314c841f8ce4b45415141a

Author: Robert Wilhelm <robert.wilhelm at gmx.net>
Date:   Sun Aug 14 11:26:12 2022 +0200

wshom: Use signed type for property ExitCode in IWshExec.

Automation interfaces should use signed types, because VBScript does not support unsigned types like VT_UI4.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53542
Signed-off-by: Robert Wilhelm <robert.wilhelm at gmx.net>

---

 dlls/wshom.ocx/shell.c         | 2 +-
 dlls/wshom.ocx/tests/wshom.idl | 2 +-
 dlls/wshom.ocx/wshom.idl       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/wshom.ocx/shell.c b/dlls/wshom.ocx/shell.c
index 5ac04e60e88..034f6583d54 100644
--- a/dlls/wshom.ocx/shell.c
+++ b/dlls/wshom.ocx/shell.c
@@ -277,7 +277,7 @@ static HRESULT WINAPI WshExec_get_ProcessID(IWshExec *iface, int *pid)
     return S_OK;
 }
 
-static HRESULT WINAPI WshExec_get_ExitCode(IWshExec *iface, DWORD *code)
+static HRESULT WINAPI WshExec_get_ExitCode(IWshExec *iface, int *code)
 {
     WshExecImpl *This = impl_from_IWshExec(iface);
 
diff --git a/dlls/wshom.ocx/tests/wshom.idl b/dlls/wshom.ocx/tests/wshom.idl
index ee9578f5ae3..cdd674460f6 100644
--- a/dlls/wshom.ocx/tests/wshom.idl
+++ b/dlls/wshom.ocx/tests/wshom.idl
@@ -439,7 +439,7 @@ library IWshRuntimeLibrary
         HRESULT ProcessID([out, retval] int *pid);
 
         [id(0x0007), propget]
-        HRESULT ExitCode([out, retval] DWORD *code);
+        HRESULT ExitCode([out, retval] int *code);
 
         [id(0x0008)]
         HRESULT Terminate();
diff --git a/dlls/wshom.ocx/wshom.idl b/dlls/wshom.ocx/wshom.idl
index c2984afc227..54de529a7a3 100644
--- a/dlls/wshom.ocx/wshom.idl
+++ b/dlls/wshom.ocx/wshom.idl
@@ -439,7 +439,7 @@ library IWshRuntimeLibrary
         HRESULT ProcessID([out, retval] int *pid);
 
         [id(0x0007), propget]
-        HRESULT ExitCode([out, retval] DWORD *code);
+        HRESULT ExitCode([out, retval] int *code);
 
         [id(0x0008)]
         HRESULT Terminate();




More information about the wine-cvs mailing list