Alex Henrie : adsldp: Fix memory leak on error path in search_ExecuteSearch (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Feb 2 16:38:03 CST 2022


Module: wine
Branch: master
Commit: 36af68289546d942759539acf65b35a9acf43b85
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=36af68289546d942759539acf65b35a9acf43b85

Author: Alex Henrie <alexhenrie24 at gmail.com>
Date:   Wed Feb  2 00:23:11 2022 -0700

adsldp: Fix memory leak on error path in search_ExecuteSearch (Coverity).

Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/adsldp/adsldp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/adsldp/adsldp.c b/dlls/adsldp/adsldp.c
index 8039065eff3..f564bc6f6cc 100644
--- a/dlls/adsldp/adsldp.c
+++ b/dlls/adsldp/adsldp.c
@@ -1302,7 +1302,11 @@ static HRESULT WINAPI search_ExecuteSearch(IDirectorySearch *iface, LPWSTR filte
         props = NULL;
     else
     {
-        if (count && !names) return E_ADS_BAD_PARAMETER;
+        if (count && !names)
+        {
+            heap_free(ldap_ctx);
+            return E_ADS_BAD_PARAMETER;
+        }
 
         props = heap_alloc((count + 1) * sizeof(props[0]));
         if (!props)




More information about the wine-cvs mailing list