Zebediah Figura : quartz/filtergraph: Remove redundant checks for pin direction from CheckCircularConnection().

Alexandre Julliard julliard at winehq.org
Thu Feb 3 16:06:56 CST 2022


Module: wine
Branch: master
Commit: ae9d64ed4cf1f1d80c5faee1b5a90a6d5739bc97
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ae9d64ed4cf1f1d80c5faee1b5a90a6d5739bc97

Author: Zebediah Figura <zfigura at codeweavers.com>
Date:   Wed Feb  2 22:58:08 2022 -0600

quartz/filtergraph: Remove redundant checks for pin direction from CheckCircularConnection().

These are already checked in the callers.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/quartz/filtergraph.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index aa646615428..74f1adcb665 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -782,22 +782,12 @@ static HRESULT CheckCircularConnection(struct filter_graph *This, IPin *out, IPi
     hr = IPin_QueryPinInfo(out, &info_out);
     if (FAILED(hr))
         return hr;
-    if (info_out.dir != PINDIR_OUTPUT)
-    {
-        IBaseFilter_Release(info_out.pFilter);
-        return VFW_E_CANNOT_CONNECT;
-    }
 
     hr = IPin_QueryPinInfo(in, &info_in);
     if (SUCCEEDED(hr))
         IBaseFilter_Release(info_in.pFilter);
     if (FAILED(hr))
         goto out;
-    if (info_in.dir != PINDIR_INPUT)
-    {
-        hr = VFW_E_CANNOT_CONNECT;
-        goto out;
-    }
 
     if (info_out.pFilter == info_in.pFilter)
         hr = VFW_E_CIRCULAR_GRAPH;




More information about the wine-cvs mailing list