Sven Baars : ntoskrnl.exe/tests: Fix some memory leaks (Valgrind).

Alexandre Julliard julliard at winehq.org
Mon Feb 14 15:41:30 CST 2022


Module: wine
Branch: master
Commit: ef437b41eebcb54a3576741fc52dbc29caa1590f
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=ef437b41eebcb54a3576741fc52dbc29caa1590f

Author: Sven Baars <sbaars at codeweavers.com>
Date:   Sun Feb 13 20:43:45 2022 +0100

ntoskrnl.exe/tests: Fix some memory leaks (Valgrind).

Signed-off-by: Sven Baars <sbaars at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntoskrnl.exe/tests/ntoskrnl.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index f53663f17d0..6207ce00ccb 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -235,11 +235,15 @@ static void testsign_cleanup(struct testsign_context *ctx)
 
     ret = CertDeleteCertificateFromStore(ctx->root_cert);
     ok(ret, "Failed to remove certificate, error %u\n", GetLastError());
+    ret = CertFreeCertificateContext(ctx->root_cert);
+    ok(ret, "Failed to free certificate context, error %u\n", GetLastError());
     ret = CertCloseStore(ctx->root_store, CERT_CLOSE_STORE_CHECK_FLAG);
     ok(ret, "Failed to close store, error %u\n", GetLastError());
 
     ret = CertDeleteCertificateFromStore(ctx->publisher_cert);
     ok(ret, "Failed to remove certificate, error %u\n", GetLastError());
+    ret = CertFreeCertificateContext(ctx->publisher_cert);
+    ok(ret, "Failed to free certificate context, error %u\n", GetLastError());
     ret = CertCloseStore(ctx->publisher_store, CERT_CLOSE_STORE_CHECK_FLAG);
     ok(ret, "Failed to close store, error %u\n", GetLastError());
 
@@ -1360,6 +1364,8 @@ static void add_file_to_catalog(HANDLE catalog, const WCHAR *file)
                 sizeof(L"2:6.0"), (BYTE *)L"2:6.0");
         ok(ret, "Failed to write attr, error %u\n", GetLastError());
     }
+
+    free(indirect_data);
 }
 
 static const GUID bus_class     = {0xdeadbeef, 0x29ef, 0x4538, {0xa5, 0xfd, 0xb6, 0x95, 0x73, 0xa3, 0x62, 0xc1}};
@@ -1816,6 +1822,8 @@ static void test_pnp_driver(struct testsign_context *ctx)
         ok(ret, "failed to remove device, error %#x\n", GetLastError());
     }
 
+    SetupDiDestroyDeviceInfoList(set);
+
     /* Windows stops the service but does not delete it. */
     manager = OpenSCManagerA(NULL, NULL, SC_MANAGER_CONNECT);
     ok(!!manager, "failed to open service manager, error %u\n", GetLastError());




More information about the wine-cvs mailing list