Nikolay Sivov : comctl32/listview: Initialize subitem text buffer before drawing each subitem.
Alexandre Julliard
julliard at winehq.org
Wed Feb 23 16:00:06 CST 2022
Module: wine
Branch: master
Commit: 4f1853c57633629ad81a233ab75a85b6f41399ad
URL: https://source.winehq.org/git/wine.git/?a=commit;h=4f1853c57633629ad81a233ab75a85b6f41399ad
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Wed Feb 23 13:48:23 2022 +0300
comctl32/listview: Initialize subitem text buffer before drawing each subitem.
Notification handler for LVN_GETDISPINFO is not guaranteed to touch text buffer.
When it doesn't, it can lead to already queried text to be reused for subitems.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52583
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/comctl32/listview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 2cb96367551..730bf4aaddd 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -4800,6 +4800,7 @@ static BOOL LISTVIEW_DrawItem(LISTVIEW_INFO *infoPtr, HDC hdc, INT nItem, ITERAT
lvItem.lParam = 0;
lvItem.cchTextMax = DISP_TEXT_SIZE;
lvItem.pszText = szDispText;
+ szDispText[0] = 0;
if (!LISTVIEW_GetItemW(infoPtr, &lvItem)) return FALSE;
if (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT)
lvItem.state = LISTVIEW_GetItemState(infoPtr, nItem, LVIS_SELECTED);
More information about the wine-cvs
mailing list