Francois Gouget : testbot/web: Clearly identify unused variables in the reset password page.

Alexandre Julliard julliard at winehq.org
Fri Jul 8 16:00:18 CDT 2022


Module: tools
Branch: master
Commit: 88bb46d5991d2c12925d08a861271da2cd41f96d
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=88bb46d5991d2c12925d08a861271da2cd41f96d

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Jul  8 15:34:44 2022 +0200

testbot/web: Clearly identify unused variables in the reset password page.

This also avoids shadowing the $User variable.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/ResetPassword.pl | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/testbot/web/ResetPassword.pl b/testbot/web/ResetPassword.pl
index 65dcdd53..b6c0ae9c 100644
--- a/testbot/web/ResetPassword.pl
+++ b/testbot/web/ResetPassword.pl
@@ -118,8 +118,8 @@ sub OnChangePassword($)
     return !1;
   }
 
-  ($ErrMessage, my $User) = $Users->Authenticate($self->GetParam("Name"),
-                                                 $self->GetParam("Password1"));
+  ($ErrMessage, my $_User) = $Users->Authenticate($self->GetParam("Name"),
+                                                  $self->GetParam("Password1"));
   if (defined $ErrMessage)
   {
     $self->AddError($ErrMessage, "Name");
@@ -127,8 +127,7 @@ sub OnChangePassword($)
   }
 
   my $Sessions = CreateSessions();
-  ($ErrMessage, my $Session) = $Sessions->NewSession($User,
-                                                     defined($self->GetParam("AutoLogin")));
+  ($ErrMessage, my $_Session) = $Sessions->NewSession($User, defined $self->GetParam("AutoLogin"));
   if ($ErrMessage)
   {
     $self->AddError($ErrMessage, "Name");




More information about the wine-cvs mailing list