Francois Gouget : testbot/web: Highlight both the 32 and 64-bit checkboxes in case of error.

Alexandre Julliard julliard at winehq.org
Tue Jul 12 16:31:44 CDT 2022


Module: tools
Branch: master
Commit: f3351e249f7ac4e4e72fcebcbebdfd851e3b5938
URL:    https://gitlab.winehq.org/winehq/tools/-/commit/f3351e249f7ac4e4e72fcebcbebdfd851e3b5938

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Jul 12 15:22:22 2022 +0200

testbot/web: Highlight both the 32 and 64-bit checkboxes in case of error.

The comment was wrong since the code explicitly checks that both
ShowRun32 and ShowRun64 are true.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/web/Submit.pl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 4368aeeb..2e6c3cc7 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -410,8 +410,7 @@ sub Validate($)
         !$self->{Run32} and $self->{ShowRun32} and
         !$self->{Run64} and $self->{ShowRun64})
     {
-      # Don't set ErrField since Run32 and Run64 may be hidden
-      $self->AddError("You must at least pick one of the 32 or 64 bit tests to run on the selected Windows VMs.");
+      $self->AddError("You must at least pick one of the 32 or 64 bit tests to run on the selected Windows VMs.", "Run32", "Run64");
       return undef;
     }
 




More information about the wine-cvs mailing list