Paul Gofman : taskschd: Return SCHED_S_TASK_HAS_NOT_RUN from regtask_get_LastRunTime() stub.

Alexandre Julliard julliard at winehq.org
Mon Jul 18 15:45:51 CDT 2022


Module: wine
Branch: master
Commit: 60a84d0e664ead23448c3297421c2f6717e3b9cd
URL:    https://gitlab.winehq.org/wine/wine/-/commit/60a84d0e664ead23448c3297421c2f6717e3b9cd

Author: Paul Gofman <pgofman at codeweavers.com>
Date:   Fri Jul 15 18:59:00 2022 -0500

taskschd: Return SCHED_S_TASK_HAS_NOT_RUN from regtask_get_LastRunTime() stub.

---

 dlls/taskschd/regtask.c         |  2 +-
 dlls/taskschd/tests/scheduler.c | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/dlls/taskschd/regtask.c b/dlls/taskschd/regtask.c
index 4c0c9130c5e..69bec19027c 100644
--- a/dlls/taskschd/regtask.c
+++ b/dlls/taskschd/regtask.c
@@ -205,7 +205,7 @@ static HRESULT WINAPI regtask_GetInstances(IRegisteredTask *iface, LONG flags, I
 static HRESULT WINAPI regtask_get_LastRunTime(IRegisteredTask *iface, DATE *date)
 {
     FIXME("%p,%p: stub\n", iface, date);
-    return E_NOTIMPL;
+    return SCHED_S_TASK_HAS_NOT_RUN;
 }
 
 static HRESULT WINAPI regtask_get_LastTaskResult(IRegisteredTask *iface, LONG *result)
diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c
index e2f985650e0..e6efd3aa1af 100644
--- a/dlls/taskschd/tests/scheduler.c
+++ b/dlls/taskschd/tests/scheduler.c
@@ -744,6 +744,7 @@ static void test_GetTask(void)
     ITaskService *service;
     ITaskFolder *root, *folder;
     IRegisteredTask *task1, *task2;
+    DATE date;
     IID iid;
     int i;
 
@@ -840,6 +841,9 @@ static void test_GetTask(void)
     ok(hr == S_OK, "get_Enabled error %#lx\n", hr);
     ok(vbool == VARIANT_FALSE, "expected VARIANT_FALSE, got %d\n", vbool);
 
+    hr = IRegisteredTask_get_LastRunTime(task1, &date);
+    ok(hr == SCHED_S_TASK_HAS_NOT_RUN, "got %#lx\n", hr);
+
     IRegisteredTask_Release(task1);
 
     hr = ITaskFolder_RegisterTask(folder, Task1, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task2);
@@ -865,6 +869,9 @@ static void test_GetTask(void)
     ok(hr == S_OK, "get_Enabled error %#lx\n", hr);
     ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool);
 
+    hr = IRegisteredTask_get_LastRunTime(task2, &date);
+    ok(hr == SCHED_S_TASK_HAS_NOT_RUN, "got %#lx\n", hr);
+
     IRegisteredTask_Release(task2);
 
     hr = ITaskFolder_GetTask(root, NULL, &task1);
@@ -891,6 +898,9 @@ static void test_GetTask(void)
     ok(hr == S_OK, "get_Enabled error %#lx\n", hr);
     ok(vbool == VARIANT_FALSE, "expected VARIANT_FALSE, got %d\n", vbool);
 
+    hr = IRegisteredTask_get_LastRunTime(task1, &date);
+    ok(hr == SCHED_S_TASK_HAS_NOT_RUN, "got %#lx\n", hr);
+
     hr = IRegisteredTask_put_Enabled(task1, VARIANT_TRUE);
     ok(hr == S_OK, "put_Enabled error %#lx\n", hr);
     hr = IRegisteredTask_get_State(task1, &state);
@@ -902,6 +912,9 @@ static void test_GetTask(void)
     todo_wine
     ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool);
 
+    hr = IRegisteredTask_get_LastRunTime(task1, &date);
+    ok(hr == SCHED_S_TASK_HAS_NOT_RUN, "got %#lx\n", hr);
+
     IRegisteredTask_Release(task1);
 
     hr = ITaskFolder_GetTask(folder, Task2, &task2);
@@ -922,6 +935,9 @@ static void test_GetTask(void)
     ok(hr == S_OK, "get_Enabled error %#lx\n", hr);
     ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool);
 
+    hr = IRegisteredTask_get_LastRunTime(task2, &date);
+    ok(hr == SCHED_S_TASK_HAS_NOT_RUN, "got %#lx\n", hr);
+
     hr = IRegisteredTask_get_State(task2, NULL);
     ok(hr == E_POINTER, "expected E_POINTER, got %#lx\n", hr);
     hr = IRegisteredTask_get_Enabled(task2, NULL);




More information about the wine-cvs mailing list